Systematically add PIP_BREAK_SYSTEM_PACKAGES to all .yml files from which pip is called.
#4705
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich pip is called.
henryiii
approved these changes
Jun 17, 2023
Collaborator
Author
|
Thanks @henryiii! |
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Jun 24, 2023
The gcc10 workaround was introduced with PR pybind#4705.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See e.g. https://veronneau.org/python-311-pip-and-breaking-system-packages.html for background.
Currently
PIP_BREAK_SYSTEM_PACKAGESis really only needed in ci.yml, but pro-actively setting it everywhere pip is called, so we don't have to come back here repeatedly in the future.Suggested changelog entry: