Go back to CMake 3.25.2 to resolve macos-latest FindCatch "Could not download" errors #4496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This fixes the CI (macos-latest). The Pip ubuntu-latest workflow is still failing, but that's for another PR. |
Collaborator
Author
|
Idea for after this PR is merged: I'll create another PR (draft) to undo this one, as a reminder to try again in a week or two. |
This was referenced Feb 7, 2023
Skylion007
approved these changes
Feb 8, 2023
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Feb 8, 2023
This reverts commit b8f2855.
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Feb 9, 2023
This reverts commit b8f2855.
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Feb 15, 2023
This reverts commit b8f2855.
henryiii
pushed a commit
to rwgk/pybind11
that referenced
this pull request
Feb 16, 2023
This reverts commit b8f2855.
henryiii
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Revert "Go back to CMake 3.25.2 (#4496)" This reverts commit b8f2855. * Apply patch provided by @bradking (with pre-commit cmake-format auto fixes). #4503 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: a draft rollback for this PR is under #4503 (for reporting the issue to the cmake developers).
I took a close look at a pair of CI logs (Python 3.11 macos-latest):
This diff looked like a smoking gun:
Suggested changelog entry: