Fix ODR violations in our Eigen Tensor tests #4412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanSteinberg
changed the title
Collaborator
Author
|
Hi @rwgk, can you take a look at this PR? I think this fixes the ODR issue in our tests. At least, based on https://github.com/pybind/pybind11/actions/runs/3720383627/jobs/6309827070 |
Skylion007
approved these changes
Dec 17, 2022
rwgk
reviewed
Dec 19, 2022
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
I'm traveling and have only very unreliable internet at the moment, therefore I couldn't try things out myself. I'll look more as soon as I can.
rwgk
approved these changes
Dec 20, 2022
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Awesome, thanks for the tweaks! With that I just had to add one line in my SConscript to adjust to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current way we are doing unit tests with Eigen unintentionally triggers ODR violations due to testing both with and without std::array.
This fixes those ODR violations by updating our build scripts.