Skip to content

Change include_guard to check target only #4338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Change include_guard to check target only #4338

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3006c1
Change include_guard to check target only
afestini Nov 16, 2022
ac2ce7c
style: pre-commit fixes
pre-commit-ci[bot] Nov 16, 2022
8f3057c
Merge branch 'master' into build_for_multiple_python_versions
henryiii Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/pybind11NewTools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ if(CMAKE_VERSION VERSION_LESS 3.12)
message(FATAL_ERROR "You cannot use the new FindPython module with CMake < 3.12")
endif()

include_guard(DIRECTORY)

get_property(
is_config
TARGET pybind11::headers
Expand Down Expand Up @@ -156,7 +154,9 @@ if(DEFINED ${_Python}_INCLUDE_DIRS)
# This needs to be a target to be included after the local pybind11
# directory, just in case there there is an installed pybind11 sitting
# next to Python's includes. It also ensures Python is a SYSTEM library.
add_library(pybind11::python_headers INTERFACE IMPORTED)
if(NOT TARGET pybind11::python_headers)
add_library(pybind11::python_headers INTERFACE IMPORTED)
endif()
set_property(
TARGET pybind11::python_headers PROPERTY INTERFACE_INCLUDE_DIRECTORIES
"$<BUILD_INTERFACE:${${_Python}_INCLUDE_DIRS}>")
Expand Down