Fix char8_t support #4278
Merged
Fix char8_t support #4278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard library macro __cpp_lib_char8_t is only available after including standard header
rwgk
approved these changes
Oct 23, 2022
Skylion007
approved these changes
Oct 23, 2022
Collaborator
|
Seems pretty cut and dry, wish our CI tests picked this up. Let's get this merged. |
henryiii
approved these changes
Oct 23, 2022
henryiii
pushed a commit
to henryiii/pybind11
that referenced
this pull request
Oct 24, 2022
Standard library macro __cpp_lib_char8_t is only available after including standard header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Standard library macro __cpp_lib_char8_t is only available after including standard header
Fixes #4277
Suggested changelog entry:
* Fix ``char8_t`` support (regression in 2.9)