Skip to content

chore: Add pytests for constructing pytypes from iterable #4138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2022
Merged

chore: Add pytests for constructing pytypes from iterable #4138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
123f2fb
Add some additional pytests
Skylion007 Aug 11, 2022
4567f01
Reorder tests
Skylion007 Aug 11, 2022
2ed14e0
Further reorder tests
Skylion007 Aug 11, 2022
f318ca1
remove stray lines
Skylion007 Aug 11, 2022
147a67b
remove unused fixtures
Skylion007 Aug 11, 2022
9b58516
Merge branch 'skylion007/extra-iterable-tests' of https://github.com/…
Skylion007 Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/test_pytypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,11 @@ TEST_SUBMODULE(pytypes, m) {
m.def("get_iterator", [] { return py::iterator(); });
// test_iterable
m.def("get_iterable", [] { return py::iterable(); });
m.def("get_frozenset_from_iterable",
[](const py::iterable &iter) { return py::frozenset(iter); });
m.def("get_list_from_iterable", [](const py::iterable &iter) { return py::list(iter); });
m.def("get_set_from_iterable", [](const py::iterable &iter) { return py::set(iter); });
m.def("get_tuple_from_iterable", [](const py::iterable &iter) { return py::tuple(iter); });
// test_float
m.def("get_float", [] { return py::float_(0.0f); });
// test_list
Expand Down
16 changes: 16 additions & 0 deletions tests/test_pytypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,22 @@ def test_iterator(doc):
assert doc(m.get_iterator) == "get_iterator() -> Iterator"


@pytest.mark.parametrize(
"pytype, from_iter_func",
[
(frozenset, m.get_frozenset_from_iterable),
(list, m.get_list_from_iterable),
(set, m.get_set_from_iterable),
(tuple, m.get_tuple_from_iterable),
],
)
def test_from_iterable(pytype, from_iter_func):
my_iter = iter(range(10))
s = from_iter_func(my_iter)
assert type(s) == pytype
assert s == pytype(range(10))


def test_iterable(doc):
assert doc(m.get_iterable) == "get_iterable() -> Iterable"

Expand Down