Skip to content

Conversation

@Skylion007
Copy link
Collaborator

Description

@Skylion007 Skylion007 requested review from henryiii and rwgk July 21, 2022 17:39
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good change. Just curious: did this cause an actual problem? (Thinking: no, but maybe I'm overlooking something?)

@Skylion007
Copy link
Collaborator Author

Definitely a good change. Just curious: did this cause an actual problem? (Thinking: no, but maybe I'm overlooking something?)

Nope, didn't cause a problem. Just noticed it when looking over the code base.

@Skylion007 Skylion007 merged commit b07975f into pybind:master Jul 22, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 22, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants