Skip to content

Conversation

@ddinu
Copy link
Contributor

@ddinu ddinu commented Jul 18, 2022

Description

The $<CONFIG:tgt> generator expression is case-insensitive, this change aligns the behavior of the explicit CMAKE_BUILD_TYPE comparisons used to determine whether debug symbols should be stripped.

I ran into this problem with a codebase that uses DEBUG instead of Debug for CMAKE_BUILD_TYPE, so debug symbols get stripped for debug builds.

Suggested changelog entry:

Avoid stripping debug symbols when `CMAKE_BUILD_TYPE` is set to `DEBUG` instead of `Debug`

@ddinu ddinu requested a review from henryiii as a code owner July 18, 2022 03:08
@henryiii henryiii merged commit 8a4bca8 into pybind:master Aug 8, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 8, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants