remove redundant copy operation. fix warning which can be interpreted as an error in some projects #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
requested changes
Nov 19, 2021
Collaborator
There was a problem hiding this comment.
You are missing a conditional here. the actual stride of the EigenConformable must be (0,0) if the negative stride boolean is not set (read the comment about bug http://eigen.tuxfamily.org/bz/show_bug.cgi?id=747). As this is implemented, I am worried it will break compatibility with old Eigen versions.
Skylion007
requested changes
Nov 19, 2021
Collaborator
Skylion007
left a comment
Skylion007
left a comment
There was a problem hiding this comment.
Yeah, older versions of Eigen will hit the static assert, so we need to make the Stride object is strictly positive for maximum backwards compatibility.
henryiii
reviewed
Nov 22, 2021
include/pybind11/eigen.h
Outdated
Comment on lines
84
to
85
| stride{EigenRowMajor ? rstride > 0 ? rstride : 0 : cstride > 0 ? cstride : 0 /* outer stride */, | ||
| EigenRowMajor ? cstride > 0 ? cstride : 0 : rstride > 0 ? rstride : 0 /* inner stride */ } { |
Collaborator
There was a problem hiding this comment.
Add parenthesis, please, I can't easily tell what's happening here.
include/pybind11/eigen.h
Outdated
| } else { | ||
| stride = {EigenRowMajor ? rstride : cstride /* outer stride */, | ||
| EigenRowMajor ? cstride : rstride /* inner stride */ }; | ||
| } |
henryiii
reviewed
Nov 22, 2021
Skylion007
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested changelog entry: