Skip to content

Avoid use of temporary bytes object in string_caster for UTF-8 #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2021
Merged

Avoid use of temporary bytes object in string_caster for UTF-8 #3257

merged 1 commit into from
Sep 9, 2021

Conversation

@jbms
Copy link
Contributor

@jbms jbms commented Sep 9, 2021

Description

Fixes #3252

Suggested changelog entry:

Conversion to ``std::string`` and ``std::string_view`` now avoids making an extra copy of the data on Python >= 3.3.

@jbms jbms mentioned this pull request Sep 9, 2021
Merged
Skylion007
Skylion007 reviewed Sep 9, 2021
View reviewed changes
Skylion007
Skylion007 reviewed Sep 9, 2021
View reviewed changes
Skylion007
Skylion007 requested changes Sep 9, 2021
View reviewed changes
@jbms jbms force-pushed the fix-3252 branch 3 times, most recently from 865269b to 9ca9fc9 Compare September 9, 2021 17:14
@jbms jbms requested a review from Skylion007 September 9, 2021 17:15
Skylion007
Skylion007 reviewed Sep 9, 2021
View reviewed changes
@Skylion007 Skylion007 merged commit 4d5ad03 into pybind:master Sep 9, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 9, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Sep 16, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwgk rwgk rwgk approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: string_caster should not use temporary on Python >= 3.3

4 participants

@jbms @rwgk @Skylion007 @henryiii