Cleanup of file-scoped and globally-scoped warning suppression pragmas across pybind11 header files. #3201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
changed the title
rwgk
changed the title
rwgk
changed the title
… 3.14 or newer). Also changing all `cmake -t` to `--target`, `-v` to `--verbose`, `check` to `pytest`, for consistency (to make it easier to pin-point all commands of a certain type). Also removing one `-j 2` for `pytest` in hopes of reducing flakes due to races in test_iostream and in prints from destructors.
…ding HINT use -isystem (as cmake does).
…tely. BTW: in the last CI run there was still a test_iostream flake, even without the -j 2 for running the tests (verfied by inspecting the log).
…(for use outside pybind11 include directory).
…n an experiment under PR pybind#3202 it is obsolete and can simply be removed.
rwgk
requested review from
Skylion007,
henryiii and
wjakob
and removed request for
wjakob
Skylion007
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most remaining file-scoped warning suppression pragmas from the pybind11 header files (all MSVC C4127), and one globally-scoped suppression (clang
-Wunsequenced). All warning suppressions in the header files are now as narrowly scoped as possible.To summarize: