Use correct duration representation when casting from datetime.timdelta to std::chrono::duration #2870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bstaletic
force-pushed
the
chrono
branch
2 times, most recently
from
a4932c1 to
ac694fc
Compare
…ta to std::chrono::duration
YannickJadoul
approved these changes
Feb 26, 2021
Collaborator
|
For the record and future reference: #2861 discusses all of this in great detail, why the current approach is an issue and how this simple change fixes things (and should cause any further issues?). |
Collaborator
|
LGTM and I ran this through our Google-global testing (just be cause it's easy and highly conclusive). Thanks @bstaletic! |
Contributor
|
@YannickJadoul Which next release version is this PR going into? |
Collaborator
|
This was merged into master. We're aiming for a 2.7 release (sorry the dev tag is currently misleading). We don't have a fixed date for the next release. I do not think the internals version will increase. You should be able to use current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is an attempt to fix #2861
Suggested changelog entry: