Skip to content

Conversation

@henryiii
Copy link
Collaborator

Description

Updating several things that are a bit dated or have new recommendations. Mostly was updating to add the min version of setuptools, as versions before 42 are buggy when used in PEP 517 mode.

Suggested changelog entry:

Just docs.

@henryiii henryiii added this to the v2.6.2 milestone Jan 14, 2021
@YannickJadoul
Copy link
Collaborator

Given that you added this to the v2.6.2 milestone: if we release 2.6.2 soon, is this necessary?

@henryiii henryiii changed the base branch from stable to master January 14, 2021 13:26
@henryiii
Copy link
Collaborator Author

It was not supposed to go to stable...

@YannickJadoul
Copy link
Collaborator

YannickJadoul commented Jan 14, 2021

Aha, yes. That makes quite some difference in the diff. I thought you were just backporting to update our stable documentation :-)

Copy link
Collaborator

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I thought I had already approved this, sorry! The looks good, as ever; thanks, @henryiii!

@henryiii henryiii merged commit 0df11d8 into master Jan 17, 2021
@henryiii henryiii deleted the henryiii-patch-1 branch January 17, 2021 01:12
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 17, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants