CMake: check for distutils presence when querying python extension module suffix #2538
Conversation
On very incomplete python installations (e.g. within Docker), it's possible that distutils is not installed. In that case, the ``execute_command`` statement that queries distutils for the Python module extension fails, and pybind11 uses the empty string. This commit adds an extra check that causes a CMake failure with more actionable information (just spent a lot of time trying to track down this problem :))
|
Sort-of related, on Windows, can we just set pyd? It's done that way here: https://gitlab.kitware.com/cmake/cmake/-/blob/39677de5e209445c8cbc5957c1e79088d5d2a03a/Modules/FindPython/Support.cmake#L3136-3138
|
|
Are you saying that we don't set the .pyd extension on Windows at the moment? Not sure that makes sense to me because extensions appear correctly named when building on Windows. |
|
No, I meant I don't think we need to query for the extension on Windows; it is always (or that could just be a fallback on Windows if this fails). |
|
But |
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
I don't think there's any reason to hold this up on not skipping Windows; and Windows might be so likely to always work here that it's not a worthwhile optimization to make.
|
Yes, in the CMake code, that's added as part of the "WITH_SOABI" option below. Okay, this is ideal, then. :) |
On very incomplete python installations (e.g. within Docker), it's
possible that distutils is not installed. In that case, the
execute_commandstatement that queries distutils for the Pythonmodule extension fails, and pybind11 uses the empty string. This commit
adds an extra check that causes a CMake failure with more actionable
information (just spent a lot of time trying to track down this problem :))