Skip to content

[READY] std::chrono::time_point doesn't work for resolutions that don't match system clock's resolution #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2020
Merged

[READY] std::chrono::time_point doesn't work for resolutions that don't match system clock's resolution #2481

merged 1 commit into from
Sep 13, 2020

Conversation

@bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Sep 12, 2020

Fixes #2035

YannickJadoul
YannickJadoul approved these changes Sep 12, 2020
View reviewed changes
Copy link
Collaborator

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bstaletic! :-) Thanks to @mhfrantz as well, for finding the issue and proposing the fix!

@henryiii henryiii merged commit cc982ac into pybind:master Sep 13, 2020
@bstaletic bstaletic deleted the res branch September 13, 2020 14:29
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryiii henryiii henryiii approved these changes

@YannickJadoul YannickJadoul YannickJadoul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Alternate system clock time point resolutions

3 participants

@bstaletic @henryiii @YannickJadoul