Add note about specifying custom base class for Exceptions. #2465
Conversation
YannickJadoul
left a comment
YannickJadoul
left a comment
There was a problem hiding this comment.
Thanks, @michalsustr! A few minor remarks, but good to have this documented :-)
| into Python exceptions of type ``PyExp``. | ||
|
|
||
| It is possible to specify base class for the exception using the third | ||
| parameter, a pointer to `PyObject`: |
There was a problem hiding this comment.
I know this is currently correct, but do we have any idea why this isn't a handle?
There was a problem hiding this comment.
No idea, first time contributing to pybind.
There was a problem hiding this comment.
No problem. Let's see if @bstaletic or anyone else knows! :-)
There was a problem hiding this comment.
Nope, no clue other than "the source says so".
There was a problem hiding this comment.
OK, let's maybe change this in a different PR, then? (Actually, we might even change this to py::type, @henryiii?)
YannickJadoul
left a comment
YannickJadoul
left a comment
There was a problem hiding this comment.
Looks good to me, once the CI gets fixed! :-)
| into Python exceptions of type ``PyExp``. | ||
|
|
||
| It is possible to specify base class for the exception using the third | ||
| parameter, a pointer to `PyObject`: |
There was a problem hiding this comment.
Nope, no clue other than "the source says so".
|
No further comments, it seems, so let's merge. (If anyone still has remarks, afterwards, it's just docs and easy enough to change.) |
|
Thanks again, @michalsustr! |
4 participants
No description provided.