Throw exception on returning a unique_ptr or shared_ptr nullptr (or any other holder type) from py::init, rather than crashing #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ny other holder type) from py::init, rather than crashing
rwgk
approved these changes
Aug 24, 2020
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Thanks Yannick for jumping in plugging this hole!
Collaborator
Author
Got curious ;-) Let's get one more review (@henryiii, @bstaletic, or maybe @EricCousineau-TRI? Don't know who's familiar with this part of the code). Then we should be fine, given how minor this change is :-) |
Collaborator
Author
|
Ow, I had tagged the wrong @henryiii, in the comment before. But given @bstaletic's review, I'll merge tomorrow morning, if no one speaks up :-) |
Collaborator
Author
|
OK, merging :-) If there's still a problem we overlooked, it can be fixed later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One overload of the implementation of
py::initwas missing this check for a null pointer that's present in the other two. This should fix it.Crash found by @rgkw in #2152 (comment).