Detection of PYBIND11 python version logic tweak #238
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
set(PYBIND11_PYTHON_VERSIONin a parent project was failing because it is overwritten inpybind11/CMakeLists.txt. This PR fixes overriding the variable if it is already defined, and defaults to the original initialization if it was undefined.Tested by successfully compiling my project with pybind11 bindings and running its test (failed when finding wrong python version) in addition to running
pybind11tests. I think this is related to functionality included in PR #207