Skip to content

Conversation

@EricCousineau-TRI
Copy link
Collaborator

Avoids potential conflict with C++20 keyword

Resolves #1593
Seemed simple enough, just a quick pass using QtCreator and some follow-up passes. Doesn't update *.rst docs.

\cc @dalboris

@EricCousineau-TRI
Copy link
Collaborator Author

Seems like other PRs are suffering from the same issues, e.g. #1641.

@jagerman TravisCI failures just seem like a URL flake. Any chance you have an idea on the MSVC front?
(Regarding this PR, I'm fine letting it stagnate for a while, but just wanted to emphasize that other PRs may be blocked by this.)

@bstaletic
Copy link
Collaborator

CI is fixed, but some tests are flaky, so try rebasing onto master.

Avoids potential conflict with C++20 keyword
@EricCousineau-TRI
Copy link
Collaborator Author

Done - thanks!

@henryiii
Copy link
Collaborator

henryiii commented Apr 7, 2019

Looks like module is okay to keep: https://en.cppreference.com/w/cpp/keyword (it’s a special identifier).

@EricCousineau-TRI
Copy link
Collaborator Author

Sweet! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants