Skip to content

Conversation

sosey
Copy link
Contributor

@sosey sosey commented May 20, 2024

This PR fixes #237 and includes actions version updates for:

  • upload-artifact
  • cache
  • setup-python
  • checkout

They were done as separate commits and should be easy to pickoff if not all of them are needed or wanted.

Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sosey There is one small typo. Thanks for updating the CI versions.

@@ -15,10 +15,10 @@ jobs:
build-test-book:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4q
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v4q
- uses: actions/checkout@v4

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks great to me! @willingc thank you for the review and catching that typo! we can merge once everything runs! approving

@lwasser lwasser merged commit dcdd937 into pyOpenSci:main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Update action versions in our builds
3 participants