Skip to content

Conversation

ptressel
Copy link
Contributor

@ptressel ptressel commented Apr 8, 2024

Use uppercase and fixed-pitch when references to license and code of conduct are more likely references to actual files. (No formatting added in alt text.) Also tweak a few grammatical issues.

…NDUCT usage

Use uppercase and fixed-pitch when references to license and code of conduct are more likely references to actual files.  (No formatting added in alt text.)  Also tweak a few grammatical issues.
@lwasser
Copy link
Member

lwasser commented Apr 8, 2024

@all-contributors please add @ptressel for code, review

Copy link
Contributor

@lwasser

I've put up a pull request to add @ptressel! 🎉

@lwasser
Copy link
Member

lwasser commented Apr 15, 2024

@ucodery i'm totally happy for you to merge these types of pr's as you feel comfortable! i'll go ahead and merge this one. I think the only time we want to have a broader review is if we're changing content . So for instance it was helpful to have ofek review the hatch content since we were updating things - he ensured it was accurate. Or if we add a new section or page to the guide we want to let our community know and have an open review period. but if the changes are fixes like this - we can review and merge :) thank you for this approval. now !

@lwasser lwasser merged commit 4e4074e into pyOpenSci:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants