Skip to content

Conversation

sneakers-the-rat
Copy link
Contributor

Currently, putting the author and maintainer all on one line makes it hard to read, and spill of the page even with the page maximized on my laptop - the example of the quirk is not visible :(

Screenshot 2024-03-01 at 2 15 22 PM Screenshot 2024-03-01 at 2 15 39 PM

Reformatted the author and description throughout so that it looks like this:
Screenshot 2024-03-01 at 2 17 42 PM

I also

  • Added a note on a "description" - there is already a nice note on the relationship between the TOML tables and arrays and python data objects, so I previewed that by saying "multiline strings are also the same" and otherwise the description doesn't get introduced
  • Modified the authors and maintainers to illustrate the concept - two initial authors, but then one of them drops out and then we gain a new friend. I think them being the same is a lil confusing

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sneakers-the-rat we can merge this. it looks really nice now! the ci issue relate to html proofer not liking hashed links to a part of a page on pypa and a few other issues unrelated to this pr. let's go ahead and merge this!

@lwasser lwasser merged commit 717be65 into pyOpenSci:main Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants