Skip to content

Bugfix: Missing quotes at xdg-open #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: Missing quotes at xdg-open #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12993b6
Bugfix: Missing quotes at xdg-open
Dec 9, 2013
286911b
Bugfix: Now opens files that contain quotes as well.
Dec 10, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vendor/xdg-open
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,15 +555,15 @@ search_desktop_file()
command_exec=`which $command 2>/dev/null`
arguments="`grep -E "^Exec(\[[^]=]*])?=" "$file" | cut -d= -f 2- | last_word`"
arg_one="`echo $arg | sed 's/&/\\\\&/g'`"
arguments_exec="`echo $arguments | sed -e 's*%[fFuU]*"'"$arg_one"'"*g'`"
arguments_exec="`echo $arguments | sed -e 's*%[fFuU]*'"$arg_one"'*g'`"

if [ -x "$command_exec" ] ; then
if echo $arguments | grep -iq '%[fFuU]' ; then
echo START $command_exec $arguments_exec
eval $command_exec $arguments_exec
eval '$command_exec "$arguments_exec"'
else
echo START $command_exec $arguments_exec "$arg"
eval $command_exec $arguments_exec "$arg"
eval '$command_exec "$arguments_exec" "$arg"'
fi

if [ $? -eq 0 ]; then
Expand Down Expand Up @@ -656,7 +656,7 @@ open_generic()
fi

if [ x"$browser_with_arg" = x"$browser" ]; then
eval '$browser $1'$xdg_redirect_output;
eval '$browser "$1"'$xdg_redirect_output;
else eval '$browser_with_arg'$xdg_redirect_output;
fi

Expand Down