-
Notifications
You must be signed in to change notification settings - Fork 200
intro_marker #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intro_marker #498
Conversation
add markers attrib to episode
|
Currently |
|
Nice. I planned to add this. My plan was reuse some bw_plex code to add this as chapters |
|
Hahaha yeah I wanted to beat anyone else to it. Was my take sufficient? |
|
I’m not sure. I think so but I havnt looked at the xml yet. You won 🎉 |
|
Applying the |
|
Nice work getting this potentially added so fast. I put these changes in my setup, and made use of them in the process listener to automatically skip the intros. Has worked well for me so for. |
for episode in plex.library.section('TV Shows').search(libtype='episode'):
if episode.hasIntroMarker:
print(episode.title + ' ready to skip intro')
else:
print(episode.title + ' analyzing...')
episode.analyze()Not sure it'd be a good idea to do that but 🤷 |
plexapi/video.py
Outdated
| """ Returns True if this episode has an intro marker in the xml. """ | ||
| if not self.isFullObject(): | ||
| self.reload() | ||
| return bool(self.markers) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would only check for intro markers in case Plex decides to add different marker types in the future.
any(marker.type == 'intro' for marker in self.markers)|
Anything else you want to add in this? |
Adding support for the new Intro Marker for episode class.
Marker class's id and tag are purely cosmetic.