Remove 'timeline/subscribe' calls #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjlawren
force-pushed
the
timeline_do_not_subscribe
branch
from
f0e6d3f to
5fe5109
Compare
Hellowlol
reviewed
May 12, 2020
Collaborator
|
What clients have you tested this against? |
Collaborator
Author
|
Plex Web, Shield, Plex desktop, iOS app. I haven't noticed any regressions in behavior. Note that I only detected issues when analyzing the Shield client logs. It doesn't cause any visible functional issues as the clients seem to treat this as a non-fatal error. |
Collaborator
|
Fix comment i made and this will be included in 4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented here and briefly described in this comment, setting up subscriptions using
timeline/subscribewill always "fail" as it's requesting the client to send callbacks to the requester on the provided port. We never create a listener to handle the async timeline updates so they always get rejected at the socket level.The original workaround for
ptpandPlex Media Playerre-subscription intervals have been left intact.