Skip to content

Fix Run SwiftLint autocorrect build phase not working #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023
Merged

Fix Run SwiftLint autocorrect build phase not working #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
575b78f
Fix `Run SwiftLint autocorrect` build phase not working
kardeslik Feb 17, 2023
a5a795f
Add changes fixed by SwiftLint
kardeslik Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PusherSwift.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "if which swiftlint >/dev/null; then\n swiftlint autocorrect\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
shellScript = "if which swiftlint >/dev/null; then\n swiftlint --fix\nelse\n echo \"warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint\"\nfi\n";
};
/* End PBXShellScriptBuildPhase section */

Expand Down
8 changes: 4 additions & 4 deletions Sources/Models/PusherChannel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ open class PusherChannel: NSObject {
eventHandlersQueue.async(flags: .barrier) { self.eventHandlersInternal = newValue }
}
}
private var _subscriptionCount: Int? = nil

private var _subscriptionCount: Int?
public var subscriptionCount: Int? {
get { return _subscriptionCount }
}

open var subscribed = false
public let name: String
open weak var connection: PusherConnection?
Expand Down Expand Up @@ -59,7 +59,7 @@ open class PusherChannel: NSObject {
self.type = PusherChannelType(name: name)
self.onSubscriptionCountChanged = onSubscriptionCountChanged
}

internal func updateSubscriptionCount(count: Int) {
self._subscriptionCount = count
self.onSubscriptionCountChanged?(count)
Expand Down
2 changes: 1 addition & 1 deletion Sources/PusherSwift.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ let CLIENT_NAME = "pusher-websocket-swift"
@objcMembers
@objc open class Pusher: NSObject {
public let connection: PusherConnection
open weak var delegate: PusherDelegate? = nil {
open weak var delegate: PusherDelegate? {
willSet {
self.connection.delegate = newValue
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/Services/PusherConnection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import NWWebSocket
open var reconnectAttemptsMax: Int?
open var reconnectAttempts: Int = 0
open var maxReconnectGapInSeconds: Double? = 120
open weak var delegate: PusherDelegate? = nil {
open weak var delegate: PusherDelegate? {
// Set the delegate for logging purposes via `debugLog(message:)`
didSet {
Logger.shared.delegate = self.delegate
Expand Down