Fix warnings #159
Merged
Fix warnings #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2017 14:41
Using `characters` is not needed anymore in Swift 4.0
Use requestFor(socketID: String, channelName: String) -> URLRequest? instead
hamchapman
reviewed
Nov 17, 2017
Sources/PusherConnection.swift
Outdated
| return true | ||
| case .authRequestBuilder(authRequestBuilder: let builder): | ||
| if let request = builder.requestFor?(socketID: socketId, channel: channel) { | ||
| if let request = builder.requestFor?(socketID: socketId, channelName: channel.name) { |
There was a problem hiding this comment.
This shouldn't be changed yet. I should have removed it with the release 5.0.0 but I forgot to do so. So now we need to wait until 6.0.0. See here: https://github.com/pusher/pusher-websocket-swift/blob/master/Sources/AuthRequestBuilderProtocol.swift#L5
This reverts commit af5cd8a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
Fix warnings in the SDK.
Why is the change necessary?
To keep project well maintained ✨
CC @pusher/mobile