-
Notifications
You must be signed in to change notification settings - Fork 140
Dev decrypt plus retry #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3a8a7bc
Add. prepareEvent method to InternalChannel interface and implement i…
daniellevass c8ea300
Refactor getInterestedListeners to it's own method in ChannelImpl
daniellevass f290cb6
Decrypt PrivateEncrypted messages and retry once
daniellevass 8ee7b59
Merge branch 'decrypt-integration' into dev-decrypt-plus-retry
daniellevass 0cf29b7
Add tests for retrying decrypting messages
daniellevass 0e178e8
Simplify the getInterestedListeners method in ChannelImpl
daniellevass 4bfc70d
Handle multiple failed decryption calls better
daniellevass 3a8f63e
When decrypting a message, pass the json map to the PusherEvent const…
daniellevass b03e466
Refactor decryptMessage to package up as a PusherEvent
daniellevass a87547f
Move the retry logic into it's own method
daniellevass 2f5b7e2
Revert "Move the retry logic into it's own method"
daniellevass 0a62b93
Keep the shared_secret after the second retry so any subsequent messa…
daniellevass e694400
Return a copy of the interestedListeners
daniellevass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstances might this be
null? If it's possible then it seems like an error we should handle, if it isn't then this check can be omitted...Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The circumstance is that we failed to decrypt an encrypted message - we return null for the
prepareEventmethod and this then means it won't notify the listeners foronEventinstead we'll be notifying them through the PrivateChannelImpl that of anonDecryptionFailure.