Skip to content

Fix warnings about manual array copying #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2020
Merged

Fix warnings about manual array copying #242

merged 2 commits into from
Mar 31, 2020

Conversation

@marekoid
Copy link
Contributor

@marekoid marekoid commented Mar 31, 2020

No description provided.

@marekoid
Copy link
Contributor Author

marekoid commented Mar 31, 2020

Those are automatic IntelliJ's proposed fixes, just the last fix in SecretBoxOpener had if (nonce.length - 16 >= 0) guard also proposed but it wasn't needed. I also added precondition check for the length of the passed nonce. It's a general secure coding practise to validate inputs (asked about validating ciphertext length too).

@marekoid marekoid requested a review from mdpye March 31, 2020 16:03
@marekoid marekoid merged commit 034efbb into decrypt-integration Mar 31, 2020
@marekoid marekoid deleted the fixManualArrayCopying branch March 31, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdpye mdpye mdpye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marekoid @mdpye