Add precondition check util #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdpye
reviewed
Mar 31, 2020
| throw new IllegalArgumentException("key should be 32B, is: " + key.length + "B"); | ||
| } | ||
| checkNotNull(key, "null key passed"); | ||
| checkArgument(key.length == 32, "key should be 32B, is: " + key.length + "B"); |
There was a problem hiding this comment.
Suggested change
| checkArgument(key.length == 32, "key should be 32B, is: " + key.length + "B"); | |
| checkArgument(key.length == 32, "key length should be 32 bytes, but is " + key.length + " bytes"); |
There was a problem hiding this comment.
not sure what was wrong with the concise form, but didn't mind much the longer one so done that: dbdea4e just couldn't apply from GH as the 100 char limit was broken
daniellevass
approved these changes
Mar 31, 2020
mdpye
approved these changes
Mar 31, 2020
daniellevass
approved these changes
Mar 31, 2020
| throw new IllegalArgumentException("key should be 32B, is: " + key.length + "B"); | ||
| } | ||
| checkNotNull(key, "null key passed"); | ||
| checkArgument(key.length == 32, "key length should be 32 bytes, but is " + |
There was a problem hiding this comment.
nit: should -> must if we're failing people for it not being what we expect.
daniellevass
approved these changes
Mar 31, 2020
mdpye
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.