Skip to content

Add Base64 char validation #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2020
Merged

Add Base64 char validation #237

merged 2 commits into from
Mar 26, 2020

Conversation

@marekoid
Copy link
Contributor

@marekoid marekoid commented Mar 26, 2020

CC @pusher/mobile

@marekoid
Add Base64 char validation
ce14b65 
Improve naming

Follow up Mike's feedback:
#236 (comment)
@marekoid marekoid mentioned this pull request Mar 26, 2020
Merged
@marekoid marekoid requested a review from mdpye March 26, 2020 15:48
mdpye
mdpye approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@mdpye mdpye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@marekoid
Use a better term
1d43fdb 
As it's not a temporary store for I/O.
@marekoid marekoid merged commit 4fed3e8 into decrypt-integration Mar 26, 2020
@marekoid marekoid deleted the base64Validation branch March 26, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdpye mdpye mdpye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marekoid @mdpye