Add NaCl's symmetric key authenticated decryption code #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied relevant bits for our decryption needs from: https://github.com/freeeve/nacl-java/blob/0369ed1b166591db9f7a2d511a3554c2376871dd/src/main/java/com/caligochat/nacl/SecretBox.java adjusting the entry point to take the key in the constructor, have preconditions checked and better signalling AuthenticityException, and added the clearKey method. Added MIT License to the copied files.
mdpye
approved these changes
Mar 24, 2020
daniellevass
approved these changes
Mar 24, 2020
| @@ -0,0 +1,137 @@ | |||
| /* | |||
| Copyright 2015 Eve Freeman | |||
There was a problem hiding this comment.
should this one have the copyright even though bits of it have been edited?
There was a problem hiding this comment.
I guess what i'm more trying to say is, should we highlight the bits which you've changed?
There was a problem hiding this comment.
it is a "substantial portion of the Software", indeed most of the stuff here is copied. I added though Pusher's copyright as well: 451a3f2
The whole SDK is also licensed on MIT so easy compatibility-wise.
Following on Danielle's feedback: https://github.com/pusher/pusher-websocket-java/pull/235/files#r397189111
daniellevass
approved these changes
Mar 24, 2020
mdpye
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied relevant bits for our decryption needs from:
https://github.com/freeeve/nacl-java/blob/0369ed1b166591db9f7a2d511a3554c2376871dd/src/main/java/com/caligochat/nacl/SecretBox.java
adjusting the entry point to take the key in the constructor,
have preconditions checked and better signalling AuthenticityException,
and added the clearKey method.
Added MIT License to the copied files.
CC @pusher/mobile