Reconnect fix #201
Merged
Reconnect fix #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2019
|
Fixes #199 |
|
does this mean there will not be any reconnect attempts anymore after this fix? |
|
No, this just correctly resets the reconnection counter so that the reconnection logic works again a second time. Before, if the connection failed and six reconnection attempts were exceeded, and the user then decided to call connect again, it would retry once, and then fail. |
WillSewell
suggested changes
Jun 17, 2019
WillSewell
force-pushed
the
reconnect_fix
branch
from
29f4064 to
b32079e
Compare
|
I added a test that fails at Without the fix in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
This PR resets the reconnectAttempts int to zero when the state machine transitions to disconnected. This means that the reconnect logic will trigger whenever .connect() is called again.
Why is the change necessary?
It's weird that the reconnection logic only works until it's exhausted, and then never again.