Skip to content

Conversation

@hdgarrood
Copy link
Contributor

Fixes #69.

This introduces a dependency on tuples, but tuples only depends on foldable-traversable itself, so this change shouldn't add any additional transitive dependencies.

@paf31
Copy link
Contributor

paf31 commented Dec 1, 2016

Another option is to use a record { before, after }, but either way we'll need to do a major version bump due to the type change.

@hdgarrood
Copy link
Contributor Author

I guess a record is more consistent with the other core libraries, e.g. uncons from both Data.Array and Data.String. I'll change it.

@hdgarrood
Copy link
Contributor Author

I guess strings is quite low down in the core hierarchy. Do we want to save this for later?

@paf31
Copy link
Contributor

paf31 commented Dec 1, 2016

Theoretically, once we're switched over to psc-package instead of Bower, these sorts of changes could be non-breaking for the package set, even though it is breaking for the package itself. Maybe if we wait, we could try that out there?

@hdgarrood
Copy link
Contributor Author

I don't see how that could work - what if people are using splitAt with its current type in their applications? I'll send a new PR anyway and we can merge it / release it when it's convenient.

@paf31
Copy link
Contributor

paf31 commented Dec 1, 2016

Sorry, you're right. What I should have said is - we'd bump the version on the package set, but we wouldn't necessarily need to rerelease all reverse dependencies. As long as they were compatible, the existing versions could stay in the new package set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants