Skip to content

Add MonadGen instance #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2017
Merged

Add MonadGen instance #78

merged 1 commit into from
May 28, 2017

Conversation

garyb
Copy link
Member

@garyb garyb commented Apr 4, 2017

No description provided.

@paf31
Copy link
Contributor

paf31 commented Apr 4, 2017 •
edited
Loading

Will QC continue to provide the same functions (elements, frequency, etc.)? I assume this will be a major version bump anyway.

Actually, we should probably merge #69 and possibly #63 while we're at it.

@garyb
Copy link
Member Author

garyb commented Apr 4, 2017

I don't think it needs to be a major version bump - there are no new dependencies (-gen's dependencies are a subset of -quickcheck's, and there are no changes to the interface).

Updating things to re-export from Gen is fine by me, I figured I'd make this change about as unobtrusive as I could, as it's just so quickcheck can be used with things written for MonadGen.

@paf31
Copy link
Contributor

paf31 commented Apr 4, 2017

👍 Seems good to me then. No real harm in a major bump actually, since everyone will only just be getting round to updating now anyway.

@paf31
Copy link
Contributor

paf31 commented May 28, 2017

Shall we merge this one?

@garyb garyb merged commit 6603ff4 into master May 28, 2017
@garyb garyb deleted the gen branch May 28, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyb @paf31