Skip to content

Conversation

paf31
Copy link
Contributor

@paf31 paf31 commented Jul 17, 2015

/cc @garyb

This allows us to run quickCheck (instead of quickCheckPure) in PSCi, where previously it failed because the compiler wouldn't find a Monad instance for the uninstantiated forall. That's still a bug in the compiler, but I think this is nicer anyway.

@garyb
Copy link
Member

garyb commented Jul 17, 2015

Ehh yes, I probably did that when I didn't know what I was doing, as I would tend to have put eff in the type these days too!

This is most likely a breaking change though, so will need a version bump.

@paf31
Copy link
Contributor Author

paf31 commented Jul 17, 2015

Yep, I'll release a major version after merging. Does this have any dependencies in core?

@paf31
Copy link
Contributor Author

paf31 commented Jul 17, 2015

Uh, reverse-dependencies, I mean.

@garyb
Copy link
Member

garyb commented Jul 17, 2015

I don't know off the top of my head, I can check in a minute. I don't think so, but possibly - it would have to be far along the dependency graph it does, so there won't be many.

paf31 added a commit that referenced this pull request Jul 17, 2015
Fix issue with instance selection in PSCi.
@paf31 paf31 merged commit 3e46bda into master Jul 17, 2015
@paf31 paf31 deleted the eff branch July 17, 2015 20:31
@garyb
Copy link
Member

garyb commented Jul 18, 2015

  • purescript-maps
  • purescript-sets
  • purescript-graphs

@paf31
Copy link
Contributor Author

paf31 commented Jul 18, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants