Fix issue with instance selection in PSCi. #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ehh yes, I probably did that when I didn't know what I was doing, as I would tend to have put This is most likely a breaking change though, so will need a version bump. |
|
Yep, I'll release a major version after merging. Does this have any dependencies in core? |
|
Uh, reverse-dependencies, I mean. |
|
I don't know off the top of my head, I can check in a minute. I don't think so, but possibly - it would have to be far along the dependency graph it does, so there won't be many. |
paf31
added a commit
that referenced
this pull request
Jul 17, 2015
Fix issue with instance selection in PSCi.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @garyb
This allows us to run
quickCheck(instead ofquickCheckPure) in PSCi, where previously it failed because the compiler wouldn't find aMonadinstance for the uninstantiatedforall. That's still a bug in the compiler, but I think this is nicer anyway.