Add Arb/CoArb instances for Unit and Ordering #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| instance arbOrdering :: Arbitrary Ordering where | ||
| arbitrary = do | ||
| n <- (3 *) <$> uniform |
There was a problem hiding this comment.
We should probably provide a wrapper for Enum to do this more generically, but for now, I think we have a combinator to generate an integer in a range. I forget the name..
There was a problem hiding this comment.
I looked through the stuff in Gen but there wasn't anything obviously suitable. Could you have a look too?
There was a problem hiding this comment.
I think chooseInt does what you need.
There was a problem hiding this comment.
Duhh, right, yeah. Thanks ;)
|
👍 Looks good, I just have one comment above. |
garyb
added a commit
that referenced
this pull request
Apr 4, 2015
Add Arb/CoArb instances for Unit and Ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @paf31