Skip to content

Migrate functions from Math; drop Math as dependency #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 25, 2022
Merged

Migrate functions from Math; drop Math as dependency #51

merged 8 commits into from
Mar 25, 2022

Conversation

@JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Mar 25, 2022

Description of the change

Part of purescript-deprecated/purescript-math#31 (comment)

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Mar 25, 2022

Blocked by purescript/purescript-numbers#18

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Mar 25, 2022
@JordanMartinez JordanMartinez changed the title Migrate trunc from math package Migrate functions from Math; drop Math as dependency Mar 25, 2022
@JordanMartinez
Copy link
Contributor Author

JordanMartinez commented Mar 25, 2022

🏓 @thomashoneyman

@thomashoneyman thomashoneyman merged commit 7bd97b7 into purescript:master Mar 25, 2022
@JordanMartinez JordanMartinez deleted the math-migration branch March 25, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @thomashoneyman