-
Notifications
You must be signed in to change notification settings - Fork 44
Add deprecation notice #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't think the wording is very nice or necessarily accurate, but sure |
|
@justinwoo I have no opinion on the wording, I just picked the notice from |
|
What is inaccurate about it? |
|
The deprecation notice should probably mention the extent to which users can expect |
|
@hdgarrood @justinwoo any suggestions for the new wording? |
|
I think we might need to step back a bit and check that we actually align on the higher-level goals here. @justinwoo: is |
|
honestly, i think the one major feature that psc-package is missing is that specifying a local package set should be as easy as giving a filepath for "set". other than that i do not expect that there are many features to add, if any, since the appeal of this tool is that it does exactly what is on the tin. i don't think applying the "deprecated" label is so fitting here though, since any proposed replacements to come are not in the same vein. do i plan to update this? maybe. i would like to, but i'm also not the most motivated person ever. however, there are a few things we can probably agree on:
considering this, we should update this README and suggest that users might want to use spago, and we might consider moving psc-package out of purescript and more fittingly into purescript-contrib or such. *edit: being on the purescript organization currently, there is a high likelihood of people assuming that psc-package is the one and main way of installing dependencies and managing purescript projects. |
|
i know the contribution graph can be misleading because i seem to have the most commits on this repo, since i have contributed some fixes and also introduced and removed a broken feature (add-from-bower), but i should say this isn't solely my project, so i don't really want to move this into my profile as some have suggested, and i hope it isn't so much of a desire from others to do so. |
|
Not deprecating |
|
@hdgarrood sounds great to me. I'd also like to see specified a policy about which kinds of contributions (ideas/bugfixes/features) are going to be considered and/or merged - i.e. clearly writing down the fact that as Justin mentioned above "there are no features to add" This has come up before in various online discussions and is the main reason for the existence of Spago, where instead all contributions/ideas are welcome (and this is fine, having a feature-frozen codebase is valuable as long as it is clearly communicated) I'm going to close this PR since the original wording is not relevant anymore |
See purescript/spago#423