Skip to content

Reimplement bindings #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Aug 1, 2023
Merged

Reimplement bindings #49

merged 28 commits into from
Aug 1, 2023

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Reimplements bindings. WIP. Blocked by purescript-node/purescript-node-url#20

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Add bindings to Incoming/OutgoingMessage
2db7ca1
@JordanMartinez
add comments for which FFI is allowed
4c8c880
@JordanMartinez
Use ty var to prevent incorrect usage
3fbea8a
@JordanMartinez
Update exports
aaa9180
@JordanMartinez
Add bindings to ClientRequest & ServerResponse
f9674ac
@JordanMartinez
Add bindings to Server
7da25fc
@JordanMartinez
Move current HTTP bindings to old
b94570c
@JordanMartinez
Finish all but Agent for node:http bindings
b4c745b
@JordanMartinez
Move Secure into old
0d08fe3
@JordanMartinez
Fix FFI name
2230214
@JordanMartinez
Implement bindings to https
c57994f
@JordanMartinez
Remove old bindings
dd39a92
@JordanMartinez
Fix FFI & export list for ClientRequest
b03db19
@JordanMartinez
Update fn to match returned type
c1b6165
@JordanMartinez
Make things not effectful
46be9dd
@JordanMartinez
Delineate between headers and cookies
e51281e
@JordanMartinez
Add opts-only-arg version of request/get
055a659
@JordanMartinez
Add FFI: implicit set/get of status code/msg
e2394d5
@JordanMartinez
Drop duplicate API for https server
f15caa7
@JordanMartinez
Unify http and https server API
9cc718b
@JordanMartinez
Rename module to Node.HTTPS
2e57d01
@JordanMartinez
Make tests compile and pass again
1afa9a8
@JordanMartinez
Add docs
bf0626c
@JordanMartinez
Update url to 7.0.0
e49ea49
@JordanMartinez
Expose URL-variant of request/get
35e7fca
@JordanMartinez
Update export lists: exclude FFI
13c4995
@JordanMartinez JordanMartinez marked this pull request as ready for review August 1, 2023 03:01
@JordanMartinez JordanMartinez merged commit bdc4a82 into master Aug 1, 2023
@JordanMartinez JordanMartinez deleted the reimplement-bindings branch August 1, 2023 03:11
This was referenced Aug 1, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JordanMartinez