Skip to content

Conversation

wclr
Copy link
Contributor

@wclr wclr commented Jun 10, 2022

Description of the change

Add options to rmdir', rm, rm'

https://nodejs.org/api/fs.html#fspromisesrmpath-options

Changes:

  • Update rmdir' to take options arg
  • Added rm and rm' version with and witout options arg

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you add an entry to the CHANGELOG.md file?

@wclr
Copy link
Contributor Author

wclr commented Jun 10, 2022

Added to changelog.

@JordanMartinez JordanMartinez merged commit 3b55fe6 into purescript-node:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants