Skip to content

Conversation

@JordanMartinez
Copy link
Contributor

Description of the change

Enables a variant of mkdir that works when multiple directories in the path don't exist.

https://nodejs.org/api/fs.html#fspromisesmkdirpath-options


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdir' is exported too, so this is a breaking change in its current form, is that the way we want to go?

@JordanMartinez
Copy link
Contributor Author

I can refactor this to use a different FFI call rather than going through mkdir'. When we do breaking changes in the future, we can merge the two then.

@JordanMartinez JordanMartinez merged commit 40dda13 into purescript-node:master Jan 8, 2022
@JordanMartinez JordanMartinez deleted the addRecursive branch January 8, 2022 15:51
@JordanMartinez JordanMartinez mentioned this pull request Jan 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants