Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Conversation

@garyb
Copy link
Member

@garyb garyb commented Apr 14, 2017

This seems to be causing problems: purescript-halogen/purescript-halogen#440 (comment)

@nwolverson, @natefaubion - technically this is a breaking change, but since the current thing is breaking more stuff, do you think a patch release would be acceptable instead?

@garyb
Copy link
Member Author

garyb commented Apr 14, 2017

Actually, this doesn't fix the problem. For the Halogen case to work, I need to change this too:

foreign import eventListener
  :: forall eff a
   . (Event -> Eff (dom :: DOM | eff) a)
  -> EventListener (dom :: DOM | eff)

Seems wrong to me...

@garyb
Copy link
Member Author

garyb commented Apr 14, 2017

Actually, maybe not 🙈... will find out for sure once I've fixed some other errors.

@garyb
Copy link
Member Author

garyb commented Apr 14, 2017

Ok yeah, just the change in this PR is required. There was something else going on that made it look like the other change was needed.

@nwolverson
Copy link
Contributor

I don't particularly care about either the particular signature here or the semver usage, I just had a drive-by comment previously but for reference, semver.org suggests a restoring-compatability change does not require a major bump.

@garyb garyb merged commit 3d9a6ad into master Apr 15, 2017
@garyb garyb deleted the event-target-row branch April 15, 2017 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants