Added some window functions and unit tests

[Risto-Stevcev]

No description provided.

[garyb]

Thanks for working on these. I'll come back to this later once Aff has been updated (for the tests).

[garyb]

Aff can be bumped to 2.0.0 now, which hopefully will get things passing again.

[Risto-Stevcev]

@garyb Got the checks to pass

[garyb]

Thanks for working on these! There's a few things I'd like removed or updated before merging though.

[garyb]

Please remove this, it's a nonstandard property - this library is intentionally only implementing standards, even when things are commonly available.

[garyb]

Please remove this one too.

[garyb]

You could implement this with Nullable instead and then use toMaybe. Something like this:

https://github.com/purescript-contrib/purescript-dom/blob/f7b786d9f005df0a41b1da63d3525b8d8ae55457/src/DOM/HTML/Event/DragEvent/DataTransfer.purs#L20-L23

The FFI code can just be currying then, with no need to handle the Nothing / Just arguments.

[garyb]

Another case where Nullable can be used.

[Risto-Stevcev]

@garyb Updated it

How do you feel about extending purescript-nullable to have Undefinable and NullOrUndefinable? Nullable is a lot easier to use than Data.Foreign.Null, but it doesn't have the equivalent Data.Foreign.Undefined and Data.Foreign.NullOrUndefined

[garyb]

Nullable is already NullOrUndefined, as it's not intended for precise data format matching like Foreign is - it's just a helper for when you have functions that might not return a value. Is the distinction necessary here? I wouldn't have though so.

[garyb]

Sorry, just noticed another thing - the argument orders are all "javascripty" rather than "purescripty" - window should be the last argument in each case, as then you can do things like:

alert "hi" =<< window

[Risto-Stevcev]

Rearranged it

[garyb]

Thanks!