Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Conversation

@kofno
Copy link
Contributor

@kofno kofno commented Oct 4, 2016

On firefox, the +files+ property on the DataTransfer object is
intentionally left null from dragover and dragenter events.

Relevant bug: https://bugzilla.mozilla.org/show_bug.cgi?id=640534

Since this isn't likely to be fixed by mozilla, the files function should
account for the possibility of a null.

kofno added 3 commits October 4, 2016 15:02
On firefox, the +files+ property on the DataTransfer object is
intentionally left null from dragover and dragenter events.

Relevant bug: https://bugzilla.mozilla.org/show_bug.cgi?id=640534

Since this isn't likely to be fixed by mozilla, the files function should
account for the possibility of a null.
@garyb
Copy link
Member

garyb commented Oct 4, 2016

Thanks for addressing this. Elsewhere we use Nullable rather than Maybe to handle this kind of thing in the API though, so would you mind using that here as well? You don't have to do anything in the JS for Nullable, you can just use it the result type.

@kofno
Copy link
Contributor Author

kofno commented Oct 4, 2016

Sure thing. I didn't notice that.

Replaces the Maybe constructor passing I was using, following the
convention already established else where.
@kofno
Copy link
Contributor Author

kofno commented Oct 5, 2016

I think this is ready now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants