This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Add API entries for UIEvents #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a large portion of the https://www.w3.org/TR/uievents/ specification.
src/DOM/Event/CompositionEvent.purs
Outdated
| import DOM.Event.Types (CompositionEvent, compositionEventToEvent, readCompositionEvent) as T | ||
|
|
||
| eventToCompositionEvent :: Event -> Maybe CompositionEvent | ||
| eventToCompositionEvent = _eventToCompositionEvent Just Nothing |
There was a problem hiding this comment.
The FFI could be avoided for these kind of functions by using Data.Foreign.unsafeReadTagged (after toForeigning the Event).
|
Thanks for working on these! Could you update the coercions to use the |
This replaces the usage of the FFI for type coercions with Data.Foreign.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a large portion of the https://www.w3.org/TR/uievents/ specification.