Type of getElementById?

[sharkdp]

Currently, getElementById is defined in the module DOM.Node.NonDocumentTypeChildNode with the following type:

getElementById :: forall eff. ElementId -> NonDocumentTypeChildNode -> Eff (dom :: DOM | eff) (Nullable Element)

Maybe I am misunderstanding something, but I don't think getElementById works on a single node level.. so I would rather expect this to be in DOM.Node.Document and to work on Document instead of NonDocumentTypeChildNode:

getElementById :: forall eff. ElementId -> Document -> Eff (dom :: DOM | eff) (Nullable Element)

See also: https://developer.mozilla.org/en-US/docs/Web/API/Document/getElementById

[garyb]

According to the DOM4 spec, this is correct: http://www.w3.org/TR/dom/#nonelementparentnode

Every Document is a NonDocumentTypeChildNode, and there is a coercion for it provided here.

[garyb]

Oh, sorry, I see the problem now... yes, looks like I made the same mistake implementing it as I did just describing it :)

The interfaces for NonDocumentTypeChildNode and NonElementParentNode have swapped implementations currently... thanks!

[sharkdp]

Well, I was also wrong, but that is the solution, yes. Thanks!