Skip to content

Edit guide to match JS DSL snippet #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

Edit guide to match JS DSL snippet #72

merged 2 commits into from
Dec 10, 2020

Conversation

milesfrain
Copy link
Member

Here are some examples to accompany the guide.

Also wanted to make sure the "browse" example matched the existing JS DSL snippet, and figured it would be best to make year an Int rather than a String.

@milesfrain milesfrain changed the title Add examples and fix "browse" behavior in guide Edit guide to match JS DSL snippet Jun 10, 2020
@milesfrain
Copy link
Member Author

Removed examples, so this PR now only contains small edits to the guide.
The examples now live in the cookbook.

@thomashoneyman thomashoneyman changed the base branch from master to main October 6, 2020 03:03
@thomashoneyman thomashoneyman merged commit 19305f0 into purescript-contrib:main Dec 10, 2020
@milesfrain milesfrain deleted the examples branch December 11, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milesfrain @thomashoneyman