Skip to content

Conversation

natefaubion
Copy link
Contributor

This restores the error behavior of choice. Previously it was left associative, so the empty node was the first thing processed (and discarded). By making it right associative, it's the last thing processed, making it identical to oneOf, which means you can often get a No alternative error which isn't helpful. This restores the previous error behavior.

I don't think this requires a changelist item.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez merged commit 9467576 into purescript-contrib:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants