Make encode function safe. #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This pull request is a follow-up to #12 as well as purescript-globals#18. With a safe
encodeURIComponentfunction available in purescript-globals as of 4.1.0, we can surface possible failure in this library'sencodeAPI by changing its type toFormURLEncoded -> Maybe String.Where should the reviewer start?
You will find that the code changes involved are minimal.
How should this be manually tested?
I figured that verifying the example shown in the README (including my small update) was a sensible test:
Other Notes:
One more thing... Thanks @thomashoneyman and @garyb for your suggestions and for making this possible to implement by updating purescript-globals.